KhaninArtur commented on a change in pull request #16482:
URL: https://github.com/apache/beam/pull/16482#discussion_r784550816
##########
File path: playground/backend/internal/preparers/java_preparers.go
##########
@@ -119,11 +143,6 @@ func replace(args ...interface{}) error {
}
func removePublicClassModifier(args ...interface{}) error {
- validationResults := args[3].(*sync.Map)
- isUnitTest, ok :=
validationResults.Load(validators.UnitTestValidatorName)
- if ok && isUnitTest.(bool) {
- return nil
- }
err := replace(args...)
return err
}
Review comment:
Here we also can directly use `replace`, can you please remove this
function?
##########
File path: playground/backend/internal/utils/preparators_utils.go
##########
@@ -17,25 +17,35 @@ package utils
Review comment:
Can we also rename this file to `preparers_utils.go`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
