laraschmidt commented on a change in pull request #16317:
URL: https://github.com/apache/beam/pull/16317#discussion_r785228904
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -2186,6 +2186,7 @@ public TimerMap timerFamily(String timerFamilyId) {
@Override
public void outputWithTimestamp(OutputT output, Instant timestamp) {
+ // checkTimestamp(timestamp);
Review comment:
This is mostly a WIP for me to figure out what was wrong so not really
ready for review. But with this uncommented dataflow on unified worker tests
break and with it commented all the other fnapi tests break. So I cannot yet
fix it until we fix it for dataflow on unified worker. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
