calvin-orange commented on a change in pull request #15863:
URL: https://github.com/apache/beam/pull/15863#discussion_r786248807
##########
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -2085,17 +2167,12 @@ private Connection getConnection() throws SQLException {
@ProcessElement
public void processElement(ProcessContext context) throws Exception {
- T record = context.element();
- records.add(record);
- if (records.size() >= spec.getBatchSize()) {
Review comment:
@pabloem Hi Pablo. Not sure if this is the right way to ask this, but I
was wondering if this removal removes the configurability of batch size? In
batchElements I see that it utilizes a constant of MAX_BUNDLE_SIZE. Seems like
it may not be utilizing batchSize anymore but I may be missing or
misunderstanding something though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
