lukecwik commented on a change in pull request #16537:
URL: https://github.com/apache/beam/pull/16537#discussion_r787020075
##########
File path:
sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataInboundObserver2.java
##########
@@ -62,6 +62,19 @@ public static BeamFnDataInboundObserver2 forConsumers(
private final Map<String, Map<String, EndpointStatus<TimerEndpoint<?>>>>
transformIdToTimerFamilyIdToTimerEndpoint;
private final CancellableQueue<BeamFnApi.Elements> queue;
+ // We use a custom exception for closing to avoid the expense of stack trace
generation.
+ protected static class CloseException extends Exception {
+ private CloseException() {
+ super(
+ "BeamFnDataInboundObserver2 closed.",
Review comment:
```suggestion
"Inbound observer closed.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
