steveniemitz commented on a change in pull request #16561:
URL: https://github.com/apache/beam/pull/16561#discussion_r788032670
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java
##########
@@ -2088,7 +2088,7 @@ public void testWriteRename() throws Exception {
for (int i = 0; i < numFinalTables; ++i) {
String tableName = "project-id:dataset-id.table_" + i;
TableDestination tableDestination = new TableDestination(tableName,
"table_" + i + "_desc");
- for (int j = 0; i < numTempTablesPerFinalTable; ++i) {
+ for (int j = 0; j < numTempTablesPerFinalTable; ++j) {
Review comment:
heh props to intellij for highlighting it. I'm pretty impressed
actually, it had a warning that `j * numTempTablesPerFinalTable + k` below
would always be 0 because j was always 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
