pabloem commented on a change in pull request #15863:
URL: https://github.com/apache/beam/pull/15863#discussion_r788239608
##########
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -2085,17 +2167,12 @@ private Connection getConnection() throws SQLException {
@ProcessElement
public void processElement(ProcessContext context) throws Exception {
- T record = context.element();
- records.add(record);
- if (records.size() >= spec.getBatchSize()) {
Review comment:
good catch. I'll fix this before the release. (2.36.0), so it'll only be
available on the next one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
