jrmccluskey commented on a change in pull request #16575:
URL: https://github.com/apache/beam/pull/16575#discussion_r788955658
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo_test.go
##########
@@ -132,10 +132,12 @@ func BenchmarkParDo_EmitSumFn(b *testing.B) {
}
go func() {
if err := p.Execute(context.Background(), "1", DataContext{});
err != nil {
- b.Fatalf("execute failed: %v", err)
+ b.Errorf("execute failed: %v", err)
Review comment:
Well looks like the issue with the blocking was because I was checking
before close(process) was called. I like the channel method better because it's
a little more clear how the error is handled compared to the error + return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
