VictorPlusC commented on a change in pull request #16555:
URL: https://github.com/apache/beam/pull/16555#discussion_r789193519
##########
File path: sdks/python/apache_beam/runners/interactive/cache_manager_test.py
##########
@@ -215,6 +215,21 @@ def test_load_saved_pcoder(self):
type(self.cache_manager.load_pcoder('full', 'a key')),
type(coders.registry.get_coder(int)))
+ def test_cache_manager_uses_ib_specified_cache_dir(self):
Review comment:
I've added two additional tests:
- test under cache_manager_test.py that:
- writes some values to a cache with default settings
- writes the same values to a cache with ib.options.cache_root
- asserts that both caches contain the same contents
- test under streaming_cache_test.py that:
- writes some values to a cache with default settings
- writes the same values to a cache with ib.options.cache_root
- asserts that both caches contain the same contents
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
