TheNeuralBit commented on a change in pull request #16522:
URL: https://github.com/apache/beam/pull/16522#discussion_r790077546
##########
File path: sdks/python/apache_beam/utils/timestamp.py
##########
@@ -269,6 +269,9 @@ def __mod__(self, other):
other = Duration.of(other)
return Duration(micros=self.micros % other.micros)
+ def __neg__(self):
+ return -self.micros
+
Review comment:
I guess we're negating a timestamp somewhere and that was triggering
invalid-unary-operand-type?
Should this return a Timestamp? e.g. `Timestamp(micros=-self.micros)`
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -3863,7 +3863,6 @@ def idxmin(self, **kwargs):
def idxmax(self, **kwargs):
return self._idxmaxmin_helper('idxmax', **kwargs)
-
Review comment:
Can you remove this unrelated change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
