pabloem commented on a change in pull request #16562:
URL: https://github.com/apache/beam/pull/16562#discussion_r791172083
##########
File path: sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
##########
@@ -216,7 +216,7 @@ def __init__(
'InfluxDB')
self.filters = filters
- def publish_metrics(self, result, extra_metrics: dict):
+ def publish_metrics(self, result, extra_metrics: dict = None):
Review comment:
you may need to tag the type as `Optional[Dict]]` so that this does not
give an error.
##########
File path: sdks/python/apache_beam/io/avroio_test.py
##########
@@ -95,7 +95,13 @@ def tearDown(self):
os.remove(path)
self._temp_files = []
- def _write_data(self, directory, prefix, codec, count, sync_interval):
+ def _write_data(
+ self,
+ directory=None,
+ prefix=None,
+ codec=None,
+ count=None,
+ sync_interval=None):
Review comment:
is this necessary if the arguments are mandatory? Are you seeing a
failure with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
