ElessarST commented on a change in pull request #16606:
URL: https://github.com/apache/beam/pull/16606#discussion_r791724383
##########
File path:
playground/frontend/lib/modules/output/components/output_header/output_header.dart
##########
@@ -43,7 +45,7 @@ class OutputHeader extends StatelessWidget {
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: [
OutputTabs(tabController: tabController),
- const OutputPlacements(),
+ isEmbedded ? const SizedBox() : const OutputPlacements(),
Review comment:
same here, `showOutputPlacements`
##########
File path:
playground/frontend/lib/modules/editor/components/editor_textarea.dart
##########
@@ -82,7 +86,9 @@ class _EditorTextAreaState extends State<EditorTextArea> {
webSpaceFix: false,
);
- _setTextScrolling();
+ if (!widget.isEmbedded) {
Review comment:
Maybe it's better to rename it to the `enableScrolling`, so we can use
it in the future on other pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
