KhaninArtur commented on a change in pull request #16593:
URL: https://github.com/apache/beam/pull/16593#discussion_r791520054
##########
File path: playground/api/v1/api.proto
##########
@@ -186,6 +186,11 @@ message GetPrecompiledObjectLogsRequest{
string cloud_path = 1;
}
+// GetPrecompiledObjectGraphRequest contains information of the
PrecompiledObject uuid.
Review comment:
Is this docstring correct?
##########
File path: playground/api/v1/api.proto
##########
@@ -211,6 +216,11 @@ message GetPrecompiledObjectLogsResponse {
string output = 1;
}
+// GetPrecompiledObjectGraphResponse represents the graph of the executed code.
Review comment:
ditto
##########
File path: playground/backend/internal/cloud_bucket/precompiled_objects.go
##########
@@ -52,6 +52,7 @@ type ObjectInfo struct {
Categories []string `json:"categories,omitempty"`
PipelineOptions string
`protobuf:"bytes,3,opt,name=pipeline_options,proto3"
json:"pipeline_options,omitempty"`
Link string
`protobuf:"bytes,3,opt,name=link,proto3" json:"link,omitempty"`
+ Graph string
`protobuf:"bytes,7,opt,name=graph,proto3" json:"graph,omitempty"`
Review comment:
Shouldn't we remove this from `ObjectInfo` then?
##########
File path: playground/backend/internal/utils/precompiled_objects_utils_test.go
##########
@@ -24,7 +24,7 @@ import (
func TestPutPrecompiledObjectsToCategory(t *testing.T) {
precompiledObjectToAdd := &cloud_bucket.PrecompiledObjects{
- {"TestName", "SDK_JAVA/TestCategory/TestName.java",
"TestDescription", pb.PrecompiledObjectType_PRECOMPILED_OBJECT_TYPE_EXAMPLE,
[]string{""}, "", ""},
+ {"TestName", "SDK_JAVA/TestCategory/TestName.java",
"TestDescription", pb.PrecompiledObjectType_PRECOMPILED_OBJECT_TYPE_EXAMPLE,
[]string{""}, "", "", ""},
Review comment:
Seems like we don't need this change then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
