[GitHub] [beam] daria-malkova commented on a change in pull request #16605: [BEAM-13634][Playground] Create a separate Dockerfile for the routing service

[GitBox]

daria-malkova commented on a change in pull request #16605:
URL: https://github.com/apache/beam/pull/16605#discussion_r792475223



##########
File path: .github/workflows/build_playground_backend.yml
##########
@@ -81,21 +81,30 @@ jobs:
       - name: Preapre Build Go
         run: ./gradlew playground:backend:containers:go:dockerTagPush 
-Pdocker-repository-root='${{ secrets.PLAYGROUND_REGISTRY_NAME}}/${{ 
secrets.PLAYGROUND_PROJECT_ID }}/playground-repository' -Pdocker-tag=${{ 
env.DOCKERTAG }}
         if: startsWith(github.ref, 'refs/tags/')
+      - name: Preapre Build Router
+        run: ./gradlew playground:backend:containers:router:dockerTagPush 
-Pdocker-repository-root='${{ secrets.PLAYGROUND_REGISTRY_NAME}}/${{ 
secrets.PLAYGROUND_PROJECT_ID }}/playground-repository' -Pdocker-tag=${{ 
env.DOCKERTAG }}
+        if: startsWith(github.ref, 'refs/tags/')
       - name: Deploy Backend Application Java
-        env: 
+        env:
           GOOGLE_APPLICATION_CREDENTIALS: /tmp/gcp_access.json
-        run: terraform init && terraform apply -auto-approve 
-var="project_id=${{ secrets.PLAYGROUND_PROJECT_ID }}" 
-var="docker_registry_address=${{ secrets.PLAYGROUND_REGISTRY_NAME}}/${{ 
secrets.PLAYGROUND_PROJECT_ID }}/playground-repository" 
-var="docker_image_tag=${{ env.DOCKERTAG }}" 
-var="service_name=backend-java-beta"
+        run: terraform init && terraform apply -auto-approve 
-var="project_id=${{ secrets.PLAYGROUND_PROJECT_ID }}" 
-var="docker_registry_address=${{ secrets.PLAYGROUND_REGISTRY_NAME}}/${{ 
secrets.PLAYGROUND_PROJECT_ID }}/playground-repository" 
-var="docker_image_tag=${{ env.DOCKERTAG }}" 
-var="service_name=backend-java${{env.STAND_SUFFIX}}"
         working-directory: playground/terraform/applications/backend-java
         if: startsWith(github.ref, 'refs/tags/')
       - name: Deploy Backend Application Go
         env:
           GOOGLE_APPLICATION_CREDENTIALS: /tmp/gcp_access.json
-        run: terraform init && terraform apply -auto-approve 
-var="project_id=${{ secrets.PLAYGROUND_PROJECT_ID }}" 
-var="docker_registry_address=${{ secrets.PLAYGROUND_REGISTRY_NAME}}/${{ 
secrets.PLAYGROUND_PROJECT_ID }}/playground-repository" 
-var="docker_image_tag=${{ env.DOCKERTAG }}" -var="service_name=backend-go-beta"
+        run: terraform init && terraform apply -auto-approve 
-var="project_id=${{ secrets.PLAYGROUND_PROJECT_ID }}" 
-var="docker_registry_address=${{ secrets.PLAYGROUND_REGISTRY_NAME}}/${{ 
secrets.PLAYGROUND_PROJECT_ID }}/playground-repository" 
-var="docker_image_tag=${{ env.DOCKERTAG }}" 
-var="service_name=backend-go${{env.STAND_SUFFIX}}"
         working-directory: playground/terraform/applications/backend-go
         if: startsWith(github.ref, 'refs/tags/')
       - name: Deploy Backend Application Python
         env:
           GOOGLE_APPLICATION_CREDENTIALS: /tmp/gcp_access.json
-        run: terraform init && terraform apply -auto-approve 
-var="project_id=${{ secrets.PLAYGROUND_PROJECT_ID }}" 
-var="docker_registry_address=${{ secrets.PLAYGROUND_REGISTRY_NAME}}/${{ 
secrets.PLAYGROUND_PROJECT_ID }}/playground-repository" 
-var="docker_image_tag=${{ env.DOCKERTAG }}" 
-var="service_name=backend-python-beta"
+        run: terraform init && terraform apply -auto-approve 
-var="project_id=${{ secrets.PLAYGROUND_PROJECT_ID }}" 
-var="docker_registry_address=${{ secrets.PLAYGROUND_REGISTRY_NAME}}/${{ 
secrets.PLAYGROUND_PROJECT_ID }}/playground-repository" 
-var="docker_image_tag=${{ env.DOCKERTAG }}" 
-var="service_name=backend-python${{env.STAND_SUFFIX}}"
         working-directory: playground/terraform/applications/backend-python
         if: startsWith(github.ref, 'refs/tags/')
+      - name: Deploy Backend Application Router
+        env:
+          GOOGLE_APPLICATION_CREDENTIALS: /tmp/gcp_access.json
+        run: terraform init && terraform apply -auto-approve 
-var="project_id=${{ secrets.PROJECT_ID_PROJECT_ID }}" 
-var="docker_registry_address=${{ secrets.PLAYGROUND_REGISTRY_NAME}}/${{ 
secrets.PLAYGROUND_PROJECT_ID }}/playground-repository" 
-var="docker_image_tag=${{ env.DOCKERTAG }}" 
-var="service_name=backend-router${{env.STAND_SUFFIX}}"
+        working-directory: playground/terraform/applications/backend-router
+        if: startsWith(github.ref, 'refs/tags/')

Review comment:
       Please add empty line at the end




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org