KhaninArtur commented on a change in pull request #16611:
URL: https://github.com/apache/beam/pull/16611#discussion_r792473823
##########
File path: playground/backend/internal/code_processing/code_processing.go
##########
@@ -535,12 +535,14 @@ func processCompileSuccess(ctx context.Context, output
[]byte, pipelineId uuid.U
// This method sets value to channel to stop goroutine which writes logs.
// After receiving a signal that goroutine was finished (read value from
finishReadLogsChannel) this method
// sets corresponding status to the cache.
-func processRunSuccess(ctx context.Context, pipelineId uuid.UUID, cacheService
cache.Cache, stopReadLogsChannel, finishReadLogsChannel chan bool) error {
+func processRunSuccess(ctx context.Context, pipelineId uuid.UUID, cacheService
cache.Cache, stopReadLogsChannel, finishReadLogsChannel chan bool, graphFolder
string) error {
logger.Infof("%s: Run() finish\n", pipelineId)
stopReadLogsChannel <- true
<-finishReadLogsChannel
+ utils.ReadAndSetToCacheGraph(ctx, cacheService, pipelineId, graphFolder)
Review comment:
Just want to confirm – can we retrieve the graph only here? Can't we
check the creation of the file and read it during the code processing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
