TheNeuralBit edited a comment on pull request #16590:
URL: https://github.com/apache/beam/pull/16590#issuecomment-1022422437
> I see a bunch of `grpc` errors in some of the unit tests. I think we can
ignore?
Yeah I think these are safe to ignore. Sometimes the GHA checks flake with
lots of `grpc.FutureTimeoutError` (BEAM-12163), in which case we can just try
re-running.
> I also see doctest errors for the `replace` method, specifically for the
`s.replace([1, 2], method='bfill')` and `s.replace('a', None)` tests. However,
when I run doctests locally, I don't see these errors. I believe these two
tests are properly accounted for under `wont_implement_ok`, but maybe I
overlooked something?
>
> Edit: I think I know why. It's because we haven't updated the version of
pandas to 1.4.0 in the precommit tasks / `setup.py`
I think your edit is correct, but that is by design. We will still verify
with pandas <1.4.0 in the Python PreCommit, because we want the API to work
with multiple minor versions of pandas.
Ideally we will find a way to modify the implementation that is still
compatible with pandas <1.4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
