benWize commented on a change in pull request #16154:
URL: https://github.com/apache/beam/pull/16154#discussion_r794960458
##########
File path: sdks/python/apache_beam/examples/complete/autocomplete.py
##########
@@ -40,7 +40,7 @@ def run(argv=None):
# We use the save_main_session option because one or more DoFn's in this
# workflow rely on global context (e.g., a module imported at module level).
pipeline_options = PipelineOptions(pipeline_args)
- pipeline_options.view_as(SetupOptions).save_main_session = True
+ pipeline_options.view_as(SetupOptions).save_main_session = save_main_session
Review comment:
I added a comment to specify save_main_session=False is used only for
testing, also I checked that this fails only for TestDirectRunner, tested for
[flink](https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Flink/7/)
and
[spark](https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Spark/9/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
