lostluck commented on a change in pull request #16629:
URL: https://github.com/apache/beam/pull/16629#discussion_r794967552
##########
File path: sdks/go/pkg/beam/core/funcx/fn.go
##########
@@ -243,6 +247,16 @@ func (u *Fn) Window() (pos int, exists bool) {
return -1, false
}
+// Pane returns (index, true) iff the function expects a PaneInfo.
+func (u *Fn) Pane() (pos int, exists bool) {
Review comment:
I won't ask you to backfill tests for all the other similar methods, but
can we ad a tests for this method, for the function having a Pane and not
having a pane?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
