yeandy commented on a change in pull request #16615:
URL: https://github.com/apache/beam/pull/16615#discussion_r795771438
##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -554,6 +554,8 @@ def test_string_tests(self):
's.str.repeat(repeats=[1, 2, 3])'
],
f'{module_name}.str_repeat': ['s.str.repeat(repeats=[1, 2, 3])'],
+ # get_dummies examples are not casted to Categorical type
+ # Must be Categorical or Bool to work in Beam
f'{module_name}.StringMethods.get_dummies': ['*'],
f'{module_name}.str_get_dummies': ['*'],
Review comment:
Should we keep the wildcard `*`, or change it to explicitly add the two
expressions from the docs? Technically, we are now implementing `get_dummies`,
but just for specific data types, so it may be misleading to say that all tests
are still `wont_implement_ok`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
