AnandInguva commented on pull request #16651: URL: https://github.com/apache/beam/pull/16651#issuecomment-1026022016
> Thank you! I think this is good to get the flakiness resolved quickly, but I bet we could resolve this before cloudpickle is the default by: > > * Modifying the test to restore `pickle_library` to it's previous value when it's done. A context manager (see [contextlib](https://docs.python.org/3/library/contextlib.html)) could be a good choice here since it will restore state even if an error occurs. > * Potentially marking this `no_xdist` (in case there are issues with running tests in parallel). I think this shouldn't actually be necessary though, as parallel tests are run in separate processes with separate global state, IIUC Yes, we can resolve it before cloudpickle is default. I will create a different PR on this later this week -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
