TheNeuralBit commented on a change in pull request #16522:
URL: https://github.com/apache/beam/pull/16522#discussion_r796083657
##########
File path: sdks/python/apache_beam/utils/timestamp_test.py
##########
@@ -132,9 +132,9 @@ def test_arithmetic(self):
with self.assertRaises(TypeError):
self.assertEqual(Duration(456) - Timestamp(123), 333)
with self.assertRaises(TypeError):
- self.assertEqual(-Timestamp(123), -123)
+ self.assertEqual(-Timestamp(123), -123) # pylint:
disable=invalid-unary-operand-type
with self.assertRaises(TypeError):
- self.assertEqual(-Timestamp(123), -Duration(123))
+ self.assertEqual(-Timestamp(123), -Duration(123)) # pylint:
disable=invalid-unary-operand-type
Review comment:
Thanks, this looks better. This test is specifically checking
unsupported operations so it makes sense that we'd need to disable a pylint
check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
