emilymye commented on a change in pull request #16675:
URL: https://github.com/apache/beam/pull/16675#discussion_r796114747
##########
File path: runners/spark/spark_runner.gradle
##########
@@ -165,12 +165,12 @@ dependencies {
implementation library.java.vendored_grpc_1_43_2
implementation library.java.vendored_guava_26_0_jre
implementation "com.codahale.metrics:metrics-core:3.0.1"
- implementation
"org.apache.spark:spark-core_$spark_scala_version:$spark_version"
- implementation
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
+ provided "org.apache.spark:spark-core_$spark_scala_version:$spark_version"
+ provided
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
permitUnusedDeclared
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
Review comment:
I ran into some issues with this with other provided deps :/
##########
File path: runners/spark/spark_runner.gradle
##########
@@ -165,12 +165,12 @@ dependencies {
implementation library.java.vendored_grpc_1_43_2
implementation library.java.vendored_guava_26_0_jre
implementation "com.codahale.metrics:metrics-core:3.0.1"
- implementation
"org.apache.spark:spark-core_$spark_scala_version:$spark_version"
- implementation
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
+ provided "org.apache.spark:spark-core_$spark_scala_version:$spark_version"
+ provided
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
permitUnusedDeclared
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
Review comment:
I ran into some issues with the checker for other provided deps :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
