TheNeuralBit commented on a change in pull request #16558:
URL: https://github.com/apache/beam/pull/16558#discussion_r796889046
##########
File path: model/pipeline/src/main/proto/schema.proto
##########
@@ -37,6 +37,7 @@ message Schema {
// REQUIRED. An RFC 4122 UUID.
string id = 2;
repeated Option options = 3;
+ repeated Option sdk_options = 5;
Review comment:
Could you document this briefly here?
##########
File path: model/pipeline/src/main/proto/schema.proto
##########
@@ -46,7 +47,7 @@ message Field {
string name = 1;
// OPTIONAL. Human readable description of this field, such as the query
that generated it.
string description = 2;
- FieldType type = 3;
+ FieldType type = 3;
Review comment:
nit: this looks unnecessary (but maybe there is an indentation issue
below)
```suggestion
FieldType type = 3;
```
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/CommonCoderTest.java
##########
@@ -334,8 +334,9 @@ private static Object convertValue(Object value,
CommonCoder coderSpec, Coder co
} else if (s.equals(getUrn(StandardCoders.Enum.ROW))) {
Schema schema;
try {
- schema =
-
SchemaTranslation.schemaFromProto(SchemaApi.Schema.parseFrom(coderSpec.getPayload()));
+ SchemaApi.Schema protoSchema;
+ protoSchema = SchemaApi.Schema.parseFrom(coderSpec.getPayload());
+ schema = SchemaTranslation.schemaFromProto(protoSchema);
Review comment:
Did anything functionally change here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
