aromanenko-dev commented on a change in pull request #16657:
URL: https://github.com/apache/beam/pull/16657#discussion_r797550764
##########
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java
##########
@@ -494,17 +495,12 @@ public Read withMaxCapacityPerShard(Integer maxCapacity) {
@Override
public PCollection<KinesisRecord> expand(PBegin input) {
+ checkNotNull(getAWSClientsProvider(), "AWSClientsProvider cannot be
null");
Review comment:
nit: better to use `checkArgument(...)` in `expand()`
##########
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisReader.java
##########
@@ -39,62 +40,42 @@
private static final Logger LOG =
LoggerFactory.getLogger(KinesisReader.class);
+ private final Read read;
Review comment:
Better to name it `spec` as we used to do for other IOs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
