pabloem commented on a change in pull request #16613:
URL: https://github.com/apache/beam/pull/16613#discussion_r798057679



##########
File path: sdks/python/apache_beam/io/jdbc.py
##########
@@ -181,8 +192,17 @@ def __init__(
     :param connection_init_sqls: required only for MySql and MariaDB.
                                  passed as list of strings
     :param expansion_service: The address (host:port) of the ExpansionService.
+    :param classpath: A list of JARs or Java packages to include in the
+                      classpath for the expansion service. This option is
+                      usually needed for `jdbc` to include extra JDBC driver
+                      packages.
+                      The packages can be in these three formats: (1) A local

Review comment:
       the new test case adds this, the local file form, and previous tests 
already verify the URL form for filesToStage, so I'd say we have this covered : 
)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to