damondouglas commented on a change in pull request #16646:
URL: https://github.com/apache/beam/pull/16646#discussion_r798822490
##########
File path: playground/terraform/applications/backend-router/main.tf
##########
@@ -29,27 +29,30 @@ resource "google_app_engine_flexible_app_version"
"backend_app_go" {
}
readiness_check {
- path = ""
+ path = "/readiness"
}
automatic_scaling {
- max_total_instances = 5
- min_total_instances = 1
+ max_total_instances = 3
Review comment:
@andreykus Perhaps in a future PR these can be terraform variables with
recommended defaults.
##########
File path: playground/terraform/applications/backend-router/main.tf
##########
@@ -29,27 +29,30 @@ resource "google_app_engine_flexible_app_version"
"backend_app_go" {
}
readiness_check {
- path = ""
+ path = "/readiness"
}
automatic_scaling {
- max_total_instances = 5
- min_total_instances = 1
+ max_total_instances = 3
+ min_total_instances = 2
cool_down_period = "120s"
cpu_utilization {
target_utilization = 0.7
}
}
resources {
- memory_gb = 4
- cpu = 2
+ memory_gb = 16
Review comment:
@andreykus Perhaps in a future PR these can be terraform variables with
recommended defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
