yeandy commented on a change in pull request #16715:
URL: https://github.com/apache/beam/pull/16715#discussion_r798984250
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -55,6 +55,15 @@
_LOGGER = logging.getLogger(__name__)
+# dest is initialized to a different name in parser.add_argument.
+# This information is needed to maintain consistent behavior
+# between flags and kwargs.
+DEPENDENT_ARGS = {
Review comment:
Maybe rename `DEPENDENT_ARGS` so that it's clear that it's a mapping?
Like `CMD_LINE_FLAG_TO_KWARGS_MAP`.
Or at least make the above comments super clear where the keys/values are
coming from. i.e.`no_use_public_ips` is passed when using command line and
`use_public_ips` when from dict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
