AnandInguva commented on a change in pull request #16633:
URL: https://github.com/apache/beam/pull/16633#discussion_r799600946
##########
File path: sdks/python/container/piputil.go
##########
@@ -51,7 +51,7 @@ func pipInstallRequirements(files []string, dir, name string)
error {
// used without following their dependencies.
args := []string{"install", "-r", filepath.Join(dir,
name), "--disable-pip-version-check", "--no-index", "--no-deps",
"--find-links", dir}
if err := execx.Execute(pip, args...); err != nil {
- return err
+ fmt.Println("Requirements cache " + dir + " is empty.
Downloading packages from PyPI")
Review comment:
Added an integration test which takes a requirements file. I added numpy
as a requirement in the .txt file. I looked at the logs and we are calling `pip
download ...`. I guess that should do it.
##########
File path: sdks/python/container/piputil.go
##########
@@ -51,7 +51,7 @@ func pipInstallRequirements(files []string, dir, name string)
error {
// used without following their dependencies.
args := []string{"install", "-r", filepath.Join(dir,
name), "--disable-pip-version-check", "--no-index", "--no-deps",
"--find-links", dir}
if err := execx.Execute(pip, args...); err != nil {
- return err
+ fmt.Println("Requirements cache " + dir + " is empty.
Downloading packages from PyPI")
Review comment:
Added an integration test which takes a requirements file. I added numpy
as a requirement in the .txt file. I looked at the logs and we are calling `pip
download ...`. I think that should do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
