lostluck commented on a change in pull request #16716:
URL: https://github.com/apache/beam/pull/16716#discussion_r799697532
##########
File path: sdks/go/pkg/beam/io/xlang/kafkaio/kafka.go
##########
@@ -92,6 +97,9 @@ const (
// Read requires the address for an expansion service for Kafka Read
transforms,
// a comma-seperated list of bootstrap server addresses (see the Kafka property
// "bootstrap.servers" for details), and at least one topic to read from.
+// If an expansion service address is not provided, one will be automatically
+// started; however this is slower than having a persistent expansion service
+// running.
Review comment:
Lets be explicit about the empty string here and below with the Write
documentation.
```suggestion
// If an expansion service address is provided as "", an appropriate
expansion
// service will be automatically started; however this is slower than having
a
// persistent expansion service
// running.
```
We likely want to have alternative functions to call in the future to change
them to an optional parameter and can mark these as Deprecated, but lets wait
until we have Go IO standards for that cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
