pabloem commented on a change in pull request #15549:
URL: https://github.com/apache/beam/pull/15549#discussion_r799890311
##########
File path:
sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
##########
@@ -447,7 +388,7 @@ public void processElement(ProcessContext c) {
}
})
.withSideInputs(empty));
- return materialized.apply(Reshuffle.viaRandomKey());
+ return materialized.apply(Distinct.create());
Review comment:
I am not ready to mark this as resolved yet - this approach using
`Distinct` may be a problem in streaming, so I want to make sure I read the
guarantees properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
