pabloem commented on a change in pull request #15848:
URL: https://github.com/apache/beam/pull/15848#discussion_r800937170
##########
File path:
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcUtilTest.java
##########
@@ -41,4 +53,126 @@ public void testGetPreparedStatementSetCaller() throws
Exception {
String expectedStmt = "INSERT INTO test_table(col1, col2, col3) VALUES(?,
?, ?)";
assertEquals(expectedStmt, generatedStmt);
}
+
+ @Test
+ public void testStringPartitioningWithSingleKeyFn() {
+ JdbcReadWithPartitionsHelper<String> helper =
+
JdbcUtil.JdbcReadWithPartitionsHelper.getPartitionsHelper(TypeDescriptors.strings());
+ List<KV<String, String>> expectedRanges =
Review comment:
oh great catch - I'd like to support strings, but I am fine to leave for
a follow up change (maybe use a specialized range object rather than a KV, huh?)
I'll remove the string support for now, and follow up in a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
