TheNeuralBit commented on a change in pull request #16720:
URL: https://github.com/apache/beam/pull/16720#discussion_r801140587
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageQueryTest.java
##########
@@ -753,6 +762,31 @@ public void testQuerySourceCreateReader() throws Exception
{
querySource.createReader(options);
}
+ @Test
+ public void testActuateProjectionPushdown() {
+ org.apache.beam.sdk.schemas.Schema schema =
+ org.apache.beam.sdk.schemas.Schema.builder()
+ .addStringField("foo")
+ .addStringField("bar")
+ .build();
+ TypedRead<Row> read =
+ BigQueryIO.read(
+ record ->
+ BigQueryUtils.toBeamRow(
+ record.getRecord(), schema,
ConversionOptions.builder().build()))
+ .withMethod(Method.DIRECT_READ)
+ .withCoder(SchemaCoder.of(schema));
Review comment:
I'm not totally clear on the difference between
`BigQueryIOStorageQueryTest` and `BigQueryIOStorageReadTest`. It looks like it
might be that the former (this file) is for tests that set `fromQuery`, with or
without method `DIRECT_READ`. While the latter is for purely `DIRECT_READ`
tests. Maybe this belongs in the latter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
