johnjcasey commented on a change in pull request #16634: URL: https://github.com/apache/beam/pull/16634#discussion_r801867562
########## File path: sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/ReadFromPulsarDoFn.java ########## @@ -0,0 +1,219 @@ +package org.apache.beam.sdk.io.pulsar; + +import com.google.common.annotations.VisibleForTesting; +import org.apache.beam.sdk.coders.Coder; +import org.apache.beam.sdk.io.range.OffsetRange; +import org.apache.beam.sdk.transforms.DoFn; +import org.apache.beam.sdk.transforms.SerializableFunction; +import org.apache.beam.sdk.transforms.splittabledofn.*; +import org.apache.beam.sdk.transforms.windowing.BoundedWindow; +import org.apache.pulsar.client.admin.PulsarAdmin; +import org.apache.pulsar.client.admin.PulsarAdminException; +import org.apache.pulsar.client.api.*; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Supplier; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Suppliers; +import org.joda.time.Instant; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.concurrent.*; + [email protected] +@SuppressWarnings("rawtypes") +public class ReadFromPulsarDoFn extends DoFn<PulsarSourceDescriptor, PulsarMessage> { + + private static final Logger LOGGER = LoggerFactory.getLogger(ReadFromPulsarDoFn.class); + private PulsarClient client; + private PulsarAdmin admin; + private String clientUrl; + private String adminUrl; + + @VisibleForTesting Reader<byte[]> readerTst; Review comment: Generally, it is better to inject dependencies like this, instead of constructing them within the method. In this case, I would look to mock the PulsarClient, so when you call .newReader on line 111 it returns the fake reader instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
