robertwb commented on a change in pull request #16761:
URL: https://github.com/apache/beam/pull/16761#discussion_r801966210
##########
File path: sdks/python/apache_beam/typehints/opcodes.py
##########
@@ -260,6 +262,13 @@ def build_list(state, arg):
state.stack[-arg:] = [List[reduce(union, state.stack[-arg:], Union[()])]]
+def build_set(state, arg):
+ if arg == 0:
+ state.stack.append(List[Union[()]])
Review comment:
Good catch. This should be list. I think this is missing in our tests
because it's there's no empty set literal in Python, but I added some tests for
set comprehension that exercise this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
