tvalentyn commented on a change in pull request #16008:
URL: https://github.com/apache/beam/pull/16008#discussion_r802039867
##########
File path: build.gradle.kts
##########
@@ -313,15 +316,23 @@ tasks.register("python38PostCommit") {
dependsOn(":sdks:python:test-suites:portable:py38:postCommitPy38")
}
+tasks.register("python39PostCommit") {
+ dependsOn(":sdks:python:test-suites:dataflow:py39:postCommitIT")
+ dependsOn(":sdks:python:test-suites:direct:py39:postCommitIT")
+ dependsOn(":sdks:python:test-suites:direct:py39:hdfsIntegrationTest")
+ dependsOn(":sdks:python:test-suites:portable:py39:postCommitPy39")
+}
+
tasks.register("portablePythonPreCommit") {
dependsOn(":sdks:python:test-suites:portable:py36:preCommitPy36")
- dependsOn(":sdks:python:test-suites:portable:py37:preCommitPy37")
+ dependsOn(":sdks:python:test-suites:portable:py39:preCommitPy39")
Review comment:
For some test suites, the main value may be in testing the highest
supported version and the lowest supported version only to save resources and
reduce execution time. But, existing suite definitions not always follow this
rule and sometimes test random versions. Some suites test all versions.
##########
File path: build.gradle.kts
##########
@@ -278,9 +279,11 @@ tasks.register("pythonDockerBuildPreCommit") {
dependsOn(":sdks:python:container:py36:docker")
dependsOn(":sdks:python:container:py37:docker")
dependsOn(":sdks:python:container:py38:docker")
+ dependsOn(":sdks:python:container:py39:docker")
}
tasks.register("pythonLintPreCommit") {
+ // TODO(BEAM-8890): Find a better way to specify lint and formatter tasks
without hardcoding py version.
Review comment:
good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
