AnandInguva commented on a change in pull request #16008:
URL: https://github.com/apache/beam/pull/16008#discussion_r802038958
##########
File path: build.gradle.kts
##########
@@ -347,12 +358,14 @@ tasks.register("runBeamDependencyCheck") {
}
tasks.register("whitespacePreCommit") {
+ // TODO(BEAM-8890): Find a better way to specify the tasks without
hardcoding py version.
Review comment:
Replace BEAM-8890 with BEAM-9980
##########
File path: .github/workflows/python_tests.yml
##########
@@ -173,12 +174,12 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
- python: [3.6, 3.7, 3.8]
+ python: [3.6, 3.7, 3.8, 3.9]
exclude:
# TODO remove exclusion after issue with protobuf is solved
# https://github.com/protocolbuffers/protobuf/issues/7765
- os: windows-latest
- python: 3.8
+ python: 3.9
Review comment:
According the PR, this is solved for 3.9[Wheels are now present for
Windows] IIUC. Can you check the PR and if it solved, can we remove the exclude
for Python 3.9?
##########
File path: build.gradle.kts
##########
@@ -347,12 +358,14 @@ tasks.register("runBeamDependencyCheck") {
}
tasks.register("whitespacePreCommit") {
+ // TODO(BEAM-8890): Find a better way to specify the tasks without
hardcoding py version.
dependsOn(":sdks:python:test-suites:tox:py38:archiveFilesToLint")
dependsOn(":sdks:python:test-suites:tox:py38:unpackFilesToLint")
dependsOn(":sdks:python:test-suites:tox:py38:whitespacelint")
}
tasks.register("typescriptPreCommit") {
+ // TODO(BEAM-8890): Find a better way to specify the tasks without
hardcoding py version.
Review comment:
Replace BEAM-8890 with BEAM-9980
##########
File path: .github/workflows/python_tests.yml
##########
@@ -140,12 +141,12 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
- python: [3.6, 3.7, 3.8]
+ python: [3.6, 3.7, 3.8, 3.9]
exclude:
# TODO remove exclusion after issue with protobuf is solved
# https://github.com/protocolbuffers/protobuf/issues/7765
- os: windows-latest
- python: 3.8
+ python: 3.9
Review comment:
According the PR, this is solved for 3.9[Wheels are now present for
Windows] IIUC. Can you check the PR and if it solved, can we remove the
`exclude` for Python 3.9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
