chamikaramj commented on a change in pull request #16838:
URL: https://github.com/apache/beam/pull/16838#discussion_r806092553
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImplTest.java
##########
@@ -908,6 +909,53 @@ public void testInsertWithinRowCountLimits() throws
Exception {
verifyWriteMetricWasSet("project", "dataset", "table", "ok", 3);
}
+ /** Tests that {@link DatasetServiceImpl#insertAll} does not go over limit
of rows per request. */
+ @Test(expected = RuntimeException.class)
Review comment:
Can we also verify the error message ?
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImplTest.java
##########
@@ -908,6 +909,53 @@ public void testInsertWithinRowCountLimits() throws
Exception {
verifyWriteMetricWasSet("project", "dataset", "table", "ok", 3);
}
+ /** Tests that {@link DatasetServiceImpl#insertAll} does not go over limit
of rows per request. */
+ @Test(expected = RuntimeException.class)
+ public void testInsertWithinRequestByteSizeLimitsErrorsOut() throws
Exception {
+ TableReference ref =
+ new
TableReference().setProjectId("project").setDatasetId("dataset").setTableId("table");
Review comment:
Can we also add a test for when retry policy is "retryTransientErrors" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
