aromanenko-dev commented on a change in pull request #16760:
URL: https://github.com/apache/beam/pull/16760#discussion_r808146182
##########
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/dynamodb/DynamoDBIO.java
##########
@@ -173,33 +190,66 @@
@AutoValue.Builder
abstract static class Builder<T> {
+ abstract Builder<T> setClientConfiguration(ClientConfiguration config);
+
abstract Builder<T> setDynamoDbClientProvider(DynamoDbClientProvider
dynamoDbClientProvider);
abstract Builder<T> setScanRequestFn(SerializableFunction<Void,
ScanRequest> fn);
abstract Builder<T> setSegmentId(Integer segmentId);
- abstract Builder<T> setScanResponseMapperFn(
- SerializableFunction<ScanResponse, T> scanResponseMapperFn);
+ abstract Builder<T>
setScanResponseMapperFn(SerializableFunction<ScanResponse, T> fn);
abstract Builder<T> setCoder(Coder<T> coder);
abstract Read<T> build();
}
- public Read<T> withDynamoDbClientProvider(DynamoDbClientProvider
dynamoDbClientProvider) {
Review comment:
Is it a breaking change. Can we just deprecate it?
I guess we may have the similar places in other classes as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
