VictorPlusC commented on a change in pull request #16741:
URL: https://github.com/apache/beam/pull/16741#discussion_r808372171
##########
File path:
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
##########
@@ -65,13 +66,18 @@ def __init__(
cluster_name)
self._cluster_name = cluster_name
else:
- self._cluster_name = self.DEFAULT_NAME
+ self._cluster_name = ie.current_env().clusters.default_cluster_name
Review comment:
Based on a few recent suggestions, I have now made it so that the
DataprocClusterManager takes in an instance of MasterURLIdentifier, which has
all of the attributes necessary for cluster configuration (project_id, region,
cluster_name). If the cluster_metadata.cluster_name is empty, we default it
here, otherwise we have noop. With this, do you think it would still be
necessary to add some `custom_cluster=False` parameter in the constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
