benWize commented on a change in pull request #16853:
URL: https://github.com/apache/beam/pull/16853#discussion_r809175670
##########
File path: sdks/python/apache_beam/examples/cookbook/coders_test.py
##########
@@ -78,24 +94,23 @@ def test_compute_points(self):
@pytest.mark.examples_postcommit
def test_coders_output_files_on_small_input(self):
test_pipeline = TestPipeline(is_integration_test=True)
-
# Setup the files with expected content.
- temp_folder = tempfile.mkdtemp()
- self.create_content_input_file(
- os.path.join(temp_folder, 'input.txt'),
- '\n'.join(map(json.dumps, self.SAMPLE_RECORDS)))
- extra_opts = {
- 'input': '%s/input.txt' % temp_folder,
- 'output': os.path.join(temp_folder, 'result')
- }
+ OUTPUT_FILE_DIR = \
Review comment:
Yes, these tests were failing in Dataflow because of the use of local
temp directories, do you think is a better option to move them to a different
file (an integration test file)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
