nbali opened a new pull request #16909: URL: https://github.com/apache/beam/pull/16909
**Please** add a meaningful description for your change here https://github.com/apache/beam/pull/15951 was the original trigger. During my tests the issue that I have encountered was that the graph and the behaviour during the actual execution differed from the one I would have expected strictly based on the `KafkaIO` configurations in the code. It happened due to multiple reasons, but this PR only aims to address one - for the rest see https://github.com/apache/beam/pull/16773 and https://github.com/apache/beam/pull/16888 So the current issue is that not every configration/property available at at the `KafkaIO.Read` works both with the legacy and the SDF implementation. On it's own this wouldn't be a problem, but unfortunately not every property was checked for this so you could configure it thinking it will work, but it won't and to make things ever worse without providing you any notice/warning about it. Also in certain scenarios the internal `PTransform` overrides replaced a working solution with another one that could result in lost functionality, because the new one might not support a feature - and to make this even worse this codepath could completely avoid any check in that regard. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/validate-runner/README.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
