AnandInguva commented on a change in pull request #16917: URL: https://github.com/apache/beam/pull/16917#discussion_r812188685
########## File path: sdks/python/apache_beam/ml/inference/run_inference.py ########## @@ -0,0 +1,43 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import apache_beam as beam +from apache_beam.ml.inference.model import ( + PytorchModel, RunInferenceModel, SklearnModel) Review comment: I think 3 import statements should be written individually to remove the Lint error. ########## File path: sdks/python/apache_beam/ml/inference/model.py ########## @@ -0,0 +1,74 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import abc + +VALID_PYTORCH_DEVICE_TYPES = ['CPU', 'GPU'] +VALID_SKLEARN_SERIALIZATION_TYPES = ['JOBLIB', 'PICKLE'] + + +class RunInferenceModel(object): + ''' + Base class for the RunInference Model. + This class contains information about + a model that is needed + ''' + def __init__(self, model_url): + self._model_url = model_url + self._validate_model() + + @abc.abstractmethod + def _validate_model(self): + raise NotImplementedError("Please implement _validate_model") + + +class PytorchModel(RunInferenceModel): + ''' + This class wraps the PyTorch model, and other + PyTorch-specific parameters + ''' + def __init__(self, model_url: str, device: str): + super().__init__(model_url) + self._device = device + self._validate_device() + + def _validate_model(self): + pass + + def _validate_device(self): + if self._device not in VALID_PYTORCH_DEVICE_TYPES: Review comment: user may provide `device=cpu`. 1. We can convert `self._device` to `self._device.upper()` to match the names in the device list -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
