liu-du edited a comment on pull request #16926:
URL: https://github.com/apache/beam/pull/16926#issuecomment-1048466314


   > BigQuery should be accepting string values here - formatting as an integer 
should be a performance change only
   
   I think it's a _correctness_ issue rather than performance change. BigQuery 
Storage Write API _rejects_ date/timestamp encoded in string format. In this 
commit 
[b56823d1d213adf6ca5564ce1d244cc4ae8f0816](https://github.com/liu-du/beam/commit/b56823d1d213adf6ca5564ce1d244cc4ae8f0816),
 I used existing conversion (use string value for date/timestamp columns) and 
add an integration test to write date/timestamp, the error I get is:
   
   `INVALID_ARGUMENT: The proto field mismatched with BigQuery field at 
Da40f0078_2574_4708_b66f_79eb0e516c43.datevalue, the proto field type string, 
BigQuery field type DATE Entity`
   
   Btw, the documented conversion is here: 
https://cloud.google.com/bigquery/docs/write-api#data_type_conversions
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to