KhaninArtur commented on a change in pull request #16912:
URL: https://github.com/apache/beam/pull/16912#discussion_r813759259
##########
File path: playground/backend/internal/fs_tool/fs_test.go
##########
@@ -30,18 +30,29 @@ const (
destinationDir = "destinationDir"
testFileMode = 0755
pipelinesFolder = "executable_files"
+ fileName = "file.txt"
+ directoryName = "incorrect"
)
+func TestMain(m *testing.M) {
+ err := prepareFiles()
+ if err != nil {
+ panic(fmt.Errorf("error during test setup: %s", err.Error()))
+ }
+ defer teardownFiles()
+ m.Run()
+}
+
func prepareFiles() error {
- err := os.Mkdir(sourceDir, testFileMode)
+ err := os.MkdirAll(filepath.Join(sourceDir, directoryName),
testFileMode)
Review comment:
Do we prepare files in the directory with the name "incorrect"? This
might be confusing, can we think about a better naming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
