liu-du commented on pull request #16926: URL: https://github.com/apache/beam/pull/16926#issuecomment-1050319966
@reuvenlax This is ready for review. A brief summary of changes: - TableFieldSchema is now passed down recursively to correctly covert date/timestamp types. - Added JavaTimeModule in [TableRowJsonCoder.java](https://github.com/apache/beam/pull/16926/files#diff-0bc4c840814c5cf4da045f15a873defedb555828faf9986a0fbd3a66c3e81279) to enable jackson to handle date/time etc. - Allow more types to be passed into TableRow (e.g. pass a java.time.Instant to a timestamp field). Type conversion is handled in TableRowToStorageApiProto.scalarToProtoValue and tested in TableRowToStorageApiProtoIT.testTableRowToStorageApiProtoITRichType - Removed the destinationDescriptorCache in StorageApiDynamicDestinationsTableRow.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
