pabloem commented on a change in pull request #16846:
URL: https://github.com/apache/beam/pull/16846#discussion_r814525377
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
##########
@@ -151,6 +177,10 @@ private static SpannerAccessor
createAndConnect(SpannerConfig spannerConfig) {
ValueProvider<String> emulatorHost = spannerConfig.getEmulatorHost();
if (emulatorHost != null) {
builder.setEmulatorHost(emulatorHost.get());
+ if (spannerConfig.getIsLocalChannelProvider() != null
+ && spannerConfig.getIsLocalChannelProvider().get()) {
+
builder.setChannelProvider(LocalChannelProvider.create(emulatorHost.get()));
Review comment:
is there any chance of passing the LocalChannelProvider from the test to
avoid depending on gax_grpc_test in the main package? It's not mandatory, but
it would make life easier for like 1% of users, who, may have version clashes
with that at some point : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
