jrmccluskey commented on a change in pull request #16952:
URL: https://github.com/apache/beam/pull/16952#discussion_r815155108
##########
File path: sdks/go/pkg/beam/core/runtime/exec/coder_test.go
##########
@@ -64,6 +68,18 @@ func TestCoders(t *testing.T) {
coder.NewDouble(),
coder.NewBool()})}),
val: &FullValue{Elm: int64(42), Elm2: &FullValue{Elm:
float64(3.14), Elm2: true}},
+ }, {
+ coder: &coder.Coder{Kind: coder.Window, Window:
coder.NewGlobalWindow()},
+ val: &FullValue{Windows:
[]typex.Window{window.GlobalWindow{}}},
+ }, {
+ coder: &coder.Coder{Kind: coder.Window, Window:
coder.NewIntervalWindow()},
+ val: &FullValue{Windows:
[]typex.Window{window.IntervalWindow{Start: 0, End: 100}}},
+ }, {
+ coder: coder.NewW(coder.NewVarInt(),
coder.NewGlobalWindow()),
+ val: &FullValue{Elm: int64(13), Windows:
[]typex.Window{window.GlobalWindow{}}},
+ }, {
+ coder: coder.NewPW(coder.NewString(),
coder.NewGlobalWindow()),
Review comment:
This case could also be split out into its own test to demonstrate the
"window in, no window out" expectation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
