liu-du commented on pull request #16926: URL: https://github.com/apache/beam/pull/16926#issuecomment-1053733060
@reuvenlax Thanks for the review. I've made changes to address the issues flagged, please have a look at the code changes. I still think the cache is not needed: 1. `TwoLevelMessageConverterCache` already cache MessageConverter twice. 2. code will be very different even if we add back caching, because it needs to cache TableSchema in addition to Descriptor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
