pavel-avilov commented on a change in pull request #16891:
URL: https://github.com/apache/beam/pull/16891#discussion_r815649844
##########
File path: playground/backend/internal/code_processing/code_processing_test.go
##########
@@ -908,51 +1009,84 @@ func Test_compileStep(t *testing.T) {
cancelChannel chan bool
}
tests := []struct {
- name string
- args args
- want *executors.Executor
- code string
+ name string
+ args args
+ code string
+ expectedStatus pb.Status
}{
{
- name: "Test compilation step working without an error",
+ name: "Test compilation step working on java sdk",
Review comment:
Done
##########
File path: playground/backend/internal/code_processing/code_processing_test.go
##########
@@ -908,51 +1009,84 @@ func Test_compileStep(t *testing.T) {
cancelChannel chan bool
}
tests := []struct {
- name string
- args args
- want *executors.Executor
- code string
+ name string
+ args args
+ code string
+ expectedStatus pb.Status
}{
{
- name: "Test compilation step working without an error",
+ name: "Test compilation step working on java sdk",
+ args: args{
+ ctx: context.Background(),
+ cacheService: cacheService,
+ pipelineId: uuid.New(),
+ sdkEnv: sdkJavaEnv,
+ isUnitTest: false,
+ pipelineLifeCycleCtx: context.Background(),
+ cancelChannel: make(chan bool, 1),
+ },
+ code: helloWordJava,
+ expectedStatus: pb.Status_STATUS_EXECUTING,
+ },
+ {
+ name: "Test compilation step working on python sdk",
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
