yirutang commented on a change in pull request #16906:
URL: https://github.com/apache/beam/pull/16906#discussion_r812518823
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWritesShardedRecords.java
##########
@@ -466,24 +495,48 @@ public String toString() {
java.time.Duration timeElapsed = java.time.Duration.between(now,
Instant.now());
appendLatencyDistribution.update(timeElapsed.toMillis());
+ idleTimer
+ .offset(streamIdleTime)
+ .withOutputTimestamp(BoundedWindow.TIMESTAMP_MAX_VALUE)
+ .setRelative();
}
- @OnWindowExpiration
- public void onWindowExpiration(
+ // called by the idleTimer and window-expiration handlers.
+ private void finalizeStream(
Review comment:
Will there be a risk of some exceptions thrown here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
