VictorPlusC commented on a change in pull request #16904:
URL: https://github.com/apache/beam/pull/16904#discussion_r816379985



##########
File path: sdks/python/apache_beam/runners/interactive/interactive_runner.py
##########
@@ -137,6 +137,20 @@ def run_pipeline(self, pipeline, options):
     watch_sources(pipeline)
 
     user_pipeline = ie.current_env().user_pipeline(pipeline)
+    if user_pipeline:
+      # When the underlying_runner is a FlinkRunner instance, create a
+      # corresponding DataprocClusterManager for it if no flink_master_url
+      # is provided.
+      master_url = self._get_dataproc_cluster_master_url_if_applicable(
+          user_pipeline)
+      if master_url:
+        flink_master_option = '--flink_master={}'.format(master_url)

Review comment:
       Sounds good! This should resolve any issues with not knowing how the 
options were instantiated.
   
   I now use `options.view_as(FlinkRunnerOptions).flink_master = master_url`, 
which seems to function much better. Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to